[PATCH] D139205: [lld][Alignment] Use Align in ELF Sections

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 10:40:30 PST 2022


MaskRay added a comment.

With this patch, the final lld executable is larger.
`llvm::Align` probably won't improve lld/ELF (and the extra dependency `llvm/Support/Alignment.h` and `MathExtras.h` is somewhat unnecessary).
I've checked using p2align for `lld::elf::Symbol`, but I think it won't decrease the struct size and will likely lead to no less code size in most call sites.

Note: I think struct size for 32-bit systems isn't really necessary. The 64-bit system behavior is much more interesting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139205/new/

https://reviews.llvm.org/D139205



More information about the llvm-commits mailing list