[PATCH] D83612: [NewPM][CodeGen] Add NPM support to llc

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I think this patch looks good as all comments are minor nits. @ychen any interest in getting it in?



================
Comment at: llvm/tools/llc/NewPMDriver.cpp:86
+                      MachineFunctionPassManager *MFPM,
+                      MachineFunctionAnalysisManager *MFAM) {
+  auto RunPM = [=]() {
----------------
Nit: Last two could be references


================
Comment at: llvm/tools/llc/NewPMDriver.cpp:99
+
+  assert(M);
+
----------------
Nit: Assertions should have messages.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83612/new/

https://reviews.llvm.org/D83612