[PATCH] D139181: [lld][Alignment][NFC] Use Align instead of log2 of alignment in Wasm Sections

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 09:31:05 PST 2022


sbc100 added inline comments.


================
Comment at: lld/wasm/OutputSegment.cpp:28
+                    << " size=" << inSeg->getSize() << " align="
+                    << Log2(inSeg->alignment) << " at:" << size << "\n");
   inSeg->outputSeg = this;
----------------
gchatelet wrote:
> sbc100 wrote:
> > How about we skip the Log2 here and write `p2align=` in the log message just to be explict?
> wait, I thought `p2align` was the log2 of alignment?
> So either `"align=" << align` or `"p2_align=" << Log2(align)`.
> 
> Let me know if I misunderstood.
At yes sorry.   I think it would be more clear if the log message said `p2align=`.. but since your change didn't effect that we don't need to make that change here.  Sorry for the noise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139181/new/

https://reviews.llvm.org/D139181



More information about the llvm-commits mailing list