[PATCH] D136335: [Assignment Tracking Analysis][5/*] Tests

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

The new two tests look good, and the documentation is highly appreciated -- is there are need to check for new "loc=none" locations being fed in, or is that something that's in the domain of LiveDebugValues? (I keep on switching back to the mindset of "every piece of information needs a dbg.value", which is not the situation in this pass).



================
Comment at: llvm/test/DebugInfo/assignment-tracking/X86/nested-loop-sroa.ll:89-97
+;; ╔═════════════╦══════════════════════════╦═════════════════╦══════════════════════════╗
+;; ║ block       ║ in                       ║ def             ║ out                      ║
+;; ╠═════════════╬══════════════════════════╬═════════════════╬══════════════════════════╣
+;; ║ entry       ║                          ║ mem=!77 dbg=!78 ║ mem=!77 dbg=!78 loc=val  ║
+;; ║ do.body     ║ mem=!77 dbg=phi loc=none ║         dbg=!77 ║ mem=!77 dbg=!77 loc=mem  ║
+;; ║ do.body1    ║ mem=!77 dbg=!77 loc=mem  ║         dbg=!77 ║ mem=!77 dbg=!77 loc=mem  ║
+;; ║ if.then     ║ mem=!77 dbg=!77 loc=mem  ║ mem=!77         ║ mem=!77 dbg=!77 loc=mem  ║
----------------
To help my understanding -- the dbg=phi on entry to do.body is because entry feeds in constant-value 9, while the assignment in do.body1 feeds in constant-value 8, yes? While stores of !77 to the stack location dominate from entry onwards.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136335/new/

https://reviews.llvm.org/D136335