[PATCH] D139199: [lld/mac] Fix --start-lib/--end-lib with split thinlto inputs

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 07:06:12 PST 2022


thakis created this revision.
thakis added a reviewer: lld-macho.
Herald added subscribers: ormris, steven_wu, hiraditya, inglorion.
Herald added projects: lld-macho, All.
thakis requested review of this revision.

Fixes #59162. The test has a comment explaining what's going on.
See also Symbol::extract() in lld/ELF/Symbols.cpp.

The included test sadly also passes if I pass just bd448f01a62 <https://reviews.llvm.org/rGbd448f01a62aacf95d671608dab1b2535c4d2cca>,
while doing that isn't enough to make my bigger repro case work
(if I port just that, something else asserts later on, but with
this fix here everything's fine in my bigger repro).


https://reviews.llvm.org/D139199

Files:
  lld/MachO/InputFiles.cpp
  lld/test/MachO/Inputs/MacOSX.sdk/usr/lib/libc++abi.tbd
  lld/test/MachO/thinlto-split-unit-start-lib.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139199.479625.patch
Type: text/x-patch
Size: 7399 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221202/8ca5dbb8/attachment.bin>


More information about the llvm-commits mailing list