[PATCH] D139000: [AMDGPU] Clear bodies of function with incompatible features

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 04:29:26 PST 2022


Pierre-vh updated this revision to Diff 479596.
Pierre-vh added a comment.

Reworked the feature compatibility checking logic to use TableGen data.
I think this is a lot more robust. I only check the features we're interested in though - I tried checking all of them and there's too many edge cases to handle them all so it's better to do this on an "opt-in" basis IMO.

With this, device libs _mostly_ builds at O0 on fiji. There's just some small codegen issue with fsin but I will try to look into it (even if it's not a known issue)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139000/new/

https://reviews.llvm.org/D139000

Files:
  llvm/include/llvm/MC/MCSubtargetInfo.h
  llvm/lib/Target/AMDGPU/AMDGPU.h
  llvm/lib/Target/AMDGPU/AMDGPUClearIncompatibleFunctions.cpp
  llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
  llvm/lib/Target/AMDGPU/CMakeLists.txt
  llvm/test/CodeGen/AMDGPU/GlobalISel/dummy-target.ll
  llvm/test/CodeGen/AMDGPU/clear-incompatible-functions.ll
  llvm/test/CodeGen/AMDGPU/llc-pipeline.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139000.479596.patch
Type: text/x-patch
Size: 53698 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221202/9e9b667d/attachment.bin>


More information about the llvm-commits mailing list