[PATCH] D115167: [DSE] Use precise loc for memset_chk during overwrite checks

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:886
+      if (TLI.getLibFunc(*CB, F) && TLI.has(F) && F == LibFunc_memset_chk) {
+        // Use the precise location size specified by the 3rd argument during
+        // for determining KillingI overwrites DeadLoc if it is a memset_chk
----------------
asbirlea wrote:
> nit: remove 'during'
Thanks, removed in the committed version!


================
Comment at: llvm/test/Transforms/DeadStoreElimination/libcalls.ll:446
 
 define void @dse_memset_chk_cannot_eliminates_store(ptr %out, i64 %n) {
 ; CHECK-LABEL: @dse_memset_chk_cannot_eliminates_store(
----------------
asbirlea wrote:
> nit: rename function without 'cannot'
I updated the tests separately, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115167/new/

https://reviews.llvm.org/D115167