[PATCH] D100808: [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 2 00:46:57 PST 2022
jhenderson added inline comments.
================
Comment at: llvm/lib/CodeGen/BasicBlockSections.cpp:263-266
+ if (&MF.front() != EntryBlock) {
+ report_fatal_error(
+ "Entry block should not be displaced by basic block sections");
+ }
----------------
Why `report_fatal_error` here? If this case can be hit by proper user code, should the error by propagated up to the call site? If not, why not an assertion?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100808/new/
https://reviews.llvm.org/D100808
More information about the llvm-commits
mailing list