[PATCH] D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86

Thu Dec 1 22:10:14 PST 2022

FreddyYe added a comment.

In D137241#3963462 <https://reviews.llvm.org/D137241#3963462>, @aaron.ballman wrote:

> In D137241#3963326 <https://reviews.llvm.org/D137241#3963326>, @FreddyYe wrote:
>
>> In D137241#3962787 <https://reviews.llvm.org/D137241#3962787>, @mgehre-amd wrote:
>>
>>> I think this was the last reason for restricting _BitInt to <= 128 by default in clang. Are you planning to create a PR to lift that restriction now?
>>
>> Yes, I agree. The patch of tests also relies on lifting first. But I'm not sure if https://github.com/llvm/llvm-project/blob/450de8008bb0ccb5dfc9dd69b6f5b434158772bd/clang/include/clang/Basic/TargetInfo.h#L637 is the only place needs to change. @aaron.ballman WDYT?
>
> Do *all* targets support > 128 now, or just x86 targets? If all targets support > 128, then that's the place to update (and we can consider starting to rip some of the target-specific machinery and command line option out). But if it's just x86, then we should override this function in the correct derived `TargetInfo` class.

I see. Thanks! I created https://reviews.llvm.org/D139170, I'll add both of you to review list. Please help review.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137241/new/

https://reviews.llvm.org/D137241