[PATCH] D137819: [XCOFF] support the overflow section.

[Paul Scoropan via Phabricator via llvm-commits]

pscoro added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:252
   std::vector<DwarfSectionEntry> DwarfSections;
+  std::vector<SectionEntry> OvrfloSections;
 
----------------
jhenderson wrote:
> Not sure why you're abbreviating here. Just use `OverflowSections`.
Seems likely because of how XCOFF documentation has abbreviated their flags: `STYP_OVRFLO` is the XCOFF flag. I agree with using full word for variable name because the full name of the section is still "Overflow section"


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:1144
-    assert(RawPointer <= MaxRawDataSize &&
-           "Section raw data overflowed this object file.");
-  }
----------------
Concerned about whether my exception section fintegrated-as support commit might conflict with how this logic was rearranged. My commit added code after this line that I assume this review wants moved elsewhere. Can we rebase against a more recent commit that includes https://reviews.llvm.org/D134195 and test? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137819/new/

https://reviews.llvm.org/D137819