[PATCH] D138496: [OMPIRBuilder] Add OpenMPDefaultSimdAlignment field to TargetMachine class
Jan Sjödin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 1 10:35:14 PST 2022
jsjodin added a comment.
If we implemented DataLayout::getMaxPreferredVectorTypeAlign something like this:
Align DataLayout::getMaxPreferredVectorTypeAlign() {
Align max(1);
for (auto &E : Alignments)
if (E.AlignType == VECTOR_ALIGN && E.PrefAlign > max)
max = E.PrefAlign;
return max;
}
Then we could find the maximum vector type alignment, This would return Align(1) by default.
In the current implementation we return 0 by default, minimum alignment should reasonably be 1 by default, unless 0 means "unknown"?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138496/new/
https://reviews.llvm.org/D138496
More information about the llvm-commits
mailing list