[PATCH] D138443: [AMDGPU] Fix GCNSubtarget::getMinNumVGPRs, add unit test to check consistency between GCNSubtarget's getMinNumVGPRs, getMaxNumVGPRs and getOccupancyWithNumVGPRs.
Valery Pykhtin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 1 09:06:43 PST 2022
vpykhtin updated this revision to Diff 479328.
vpykhtin marked an inline comment as done.
vpykhtin added a comment.
- Replaced call to getNumWavesPerEUWithNumVGPRs with NumVGPRs above addressable with better code.
- Assert cannot be added right now at getNumWavesPerEUWithNumVGPRs because it fail other tests.
- Better naming.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138443/new/
https://reviews.llvm.org/D138443
Files:
llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
llvm/lib/Target/AMDGPU/GCNSubtarget.h
llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
llvm/test/CodeGen/AMDGPU/occupancy-levels.ll
llvm/unittests/Target/AMDGPU/AMDGPUUnitTests.cpp
llvm/unittests/Target/AMDGPU/AMDGPUUnitTests.h
llvm/unittests/Target/AMDGPU/CMakeLists.txt
llvm/unittests/Target/AMDGPU/DwarfRegMappings.cpp
llvm/unittests/Target/AMDGPU/ExecMayBeModifiedBeforeAnyUse.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138443.479328.patch
Type: text/x-patch
Size: 15508 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221201/d6a6c24f/attachment.bin>
More information about the llvm-commits
mailing list