[PATCH] D138495: [openmp][mlir] Lower parallel if to new fork_call_if function.

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 1 08:51:10 PST 2022


DavidTruby updated this revision to Diff 479316.
DavidTruby added a comment.

Make compatible with C and add unit test.

Adding the unit test also exposed an additional bug where no arguments are
passed if the region doesn't capture any variables. Instead we create a void
pointer to pass to `fork_call_if` in that case, and then check if that argument
exists before passing it on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138495/new/

https://reviews.llvm.org/D138495

Files:
  llvm/include/llvm/Frontend/OpenMP/OMPKinds.def
  llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
  llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
  mlir/test/Target/LLVMIR/openmp-llvm.mlir
  openmp/runtime/src/kmp.h
  openmp/runtime/src/kmp_csupport.cpp
  openmp/runtime/test/lit.cfg
  openmp/runtime/test/parallel/omp_parallel_if.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138495.479316.patch
Type: text/x-patch
Size: 15880 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221201/e29acd5d/attachment.bin>


More information about the llvm-commits mailing list