[PATCH] D139051: [PGO][indirect-call-promotion] Add extra parameter check for musttail callsite

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm with a couple comment suggestions for test



================
Comment at: llvm/test/Transforms/PGOProfile/indirect_call_promotion_musttail_typecheck.ll:12
+; CHECK:       1:
+; CHECK-NEXT:    [[CALL11_I:%.*]] = musttail call ptr [[TMP0]](ptr null, ptr null, ptr null, i64 0, ptr null, i64 0), !prof [[PROF0:![0-9]+]]
+; CHECK-NEXT:    ret ptr [[CALL11_I]]
----------------
Add comment that we are checking that there was no icp due to parameter mismatch.


================
Comment at: llvm/test/Transforms/PGOProfile/indirect_call_promotion_musttail_typecheck.ll:33
+; CHECK:       if.true.direct_targ:
+; CHECK-NEXT:    [[TMP3:%.*]] = musttail call ptr @_ZN6proto28internal12ExtensionSet10ParseFieldEmPKcPKNS_7MessageEPNS0_16InternalMetadataEPNS0_12ParseContextE(ptr null, i64 0, ptr null, ptr null, ptr null, ptr null)
+; CHECK-NEXT:    ret ptr [[TMP3]]
----------------
Add comment that we are checking that icp succeeded since the parameter types match and that the promoted call is also musttail.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139051/new/

https://reviews.llvm.org/D139051