[llvm] 2ab7c7e - [X86] Remove unnecessary RDRAND overrides from znver1/znver2 model

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 1 05:41:51 PST 2022


Author: Simon Pilgrim
Date: 2022-12-01T13:41:43Z
New Revision: 2ab7c7e50a85bf9c528e92f566b0551ede6ad5b2

URL: https://github.com/llvm/llvm-project/commit/2ab7c7e50a85bf9c528e92f566b0551ede6ad5b2
DIFF: https://github.com/llvm/llvm-project/commit/2ab7c7e50a85bf9c528e92f566b0551ede6ad5b2.diff

LOG: [X86] Remove unnecessary RDRAND overrides from znver1/znver2 model

Reported by D138359 - the overrides matched the base class schedule definition (its been flagged as WriteMicrocoded instead of WriteSystem but the models define both the same)

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ScheduleZnver1.td
    llvm/lib/Target/X86/X86ScheduleZnver2.td

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ScheduleZnver1.td b/llvm/lib/Target/X86/X86ScheduleZnver1.td
index 1ad74f43e07a..124a8a71b9a7 100644
--- a/llvm/lib/Target/X86/X86ScheduleZnver1.td
+++ b/llvm/lib/Target/X86/X86ScheduleZnver1.td
@@ -752,9 +752,6 @@ def : InstRW<[ZnWriteLEAVE], (instregex "LEAVE")>;
 // PAUSE.
 def : InstRW<[WriteMicrocoded], (instrs PAUSE)>;
 
-// RDRAND.
-def : InstRW<[WriteMicrocoded], (instrs RDRAND16r, RDRAND32r, RDRAND64r)>;
-
 // XADD.
 def ZnXADD : SchedWriteRes<[ZnALU]>;
 def : InstRW<[ZnXADD], (instregex "XADD(8|16|32|64)rr")>;

diff  --git a/llvm/lib/Target/X86/X86ScheduleZnver2.td b/llvm/lib/Target/X86/X86ScheduleZnver2.td
index 6cb81dc684fa..aa7b0df0b5bc 100644
--- a/llvm/lib/Target/X86/X86ScheduleZnver2.td
+++ b/llvm/lib/Target/X86/X86ScheduleZnver2.td
@@ -762,9 +762,6 @@ def : InstRW<[Zn2WriteLEAVE], (instregex "LEAVE")>;
 // PAUSE.
 def : InstRW<[WriteMicrocoded], (instrs PAUSE)>;
 
-// RDRAND.
-def : InstRW<[WriteMicrocoded], (instregex "RDRAND(16|32|64)r")>;
-
 // XADD.
 def Zn2XADD : SchedWriteRes<[Zn2ALU]>;
 def : InstRW<[Zn2XADD], (instregex "XADD(8|16|32|64)rr")>;


        


More information about the llvm-commits mailing list