[PATCH] D138658: [DebugInfo] Store optional DIFile::Source as pointer

[Jonas Hahnfeld via Phabricator via llvm-commits]

Hahnfeld updated this revision to Diff 479258.
Hahnfeld retitled this revision from "[DebugInfo] Protect DIFile::Source against empty string" to "[DebugInfo] Store optional DIFile::Source as pointer".
Hahnfeld edited the summary of this revision.
Hahnfeld added a reviewer: scott.linder.
Hahnfeld added a comment.
Herald added a subscriber: hiraditya.

Thanks for the discussion. I updated the patch to remove the `Optional` wrapping a `MDString *`, PTAL.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138658/new/

https://reviews.llvm.org/D138658

Files:
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/lib/AsmParser/LLParser.cpp
  llvm/lib/Bitcode/Reader/MetadataLoader.cpp
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/lib/IR/DebugInfoMetadata.cpp
  llvm/lib/IR/LLVMContextImpl.h
  llvm/unittests/IR/DebugInfoTest.cpp
  llvm/unittests/IR/MetadataTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138658.479258.patch
Type: text/x-patch
Size: 9722 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221201/b7e3e39a/attachment-0001.bin>