[PATCH] D131863: [CodeGen] Fix restore blocks' BasicBlock information in branch relaxation

Thu Dec 1 05:34:57 PST 2022

piggynl added a comment.

Yes, exactly. Thank you for your time on this patch!

In D131863#3963335 <https://reviews.llvm.org/D131863#3963335>, @arsenm wrote:

> In D131863#3963263 <https://reviews.llvm.org/D131863#3963263>, @piggynl wrote:
>
>> Because if the generated restore blocks have the incorrect BasicBlock information, like the `# %dest_3` for `.LBB8_6` and `.LBB6_10` before this change, they would be confusing. Although I believe it is also acceptable if they contain no corresponding BasicBlock information, it will be easier to understand if they do, such as the '# %dest 1' with '.LBB8_6' and '# %dest 2' with '.LBB6_10' after this change.
>
> OK, so it's just a comment change - nonfunctional

Yes, exactly. Thank you for your time on this patch!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131863/new/

https://reviews.llvm.org/D131863