[PATCH] D139097: [ARM] Fix Address value difference for symbol emitted by llvm-nm

Shankar Easwaran via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 1 05:25:11 PST 2022


shankare added inline comments.


================
Comment at: llvm/include/llvm/Object/ELFObjectFile.h:562-565
+  if ((Header.e_machine == ELF::EM_MIPS) &&
       (*SymOrErr)->getType() == ELF::STT_FUNC)
     Ret &= ~1;
 
----------------
Should this be removed even for MIPS ?

Its better that the caller handle it appropriately.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139097/new/

https://reviews.llvm.org/D139097



More information about the llvm-commits mailing list