[PATCH] D131863: [CodeGen] Fix restore blocks' BasicBlock information in branch relaxation
    Piggy via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Dec  1 04:45:09 PST 2022
    
    
  
piggynl added a comment.
Because if the generated restore blocks have the incorrect BasicBlock information, like the `# %dest_3` for `.LBB6_8` and `.LBB6_10` before this change, they would be confusing. Although I believe it is also acceptable if they contain no corresponding BasicBlock information, it will be easier to understand if they do, such as the '# %dest 1' with '.LBB8_6' and '# %dest 2' with '.LBB6_10' after this change.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131863/new/
https://reviews.llvm.org/D131863
    
    
More information about the llvm-commits
mailing list