[PATCH] D139074: Vectorization Of Conditional Statements Using BOSCC

Nuno Lopes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 1 00:31:27 PST 2022


nlopes added inline comments.


================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:586
+      Constant *PromoteMaskConst = ConstantVector::get(PromoteMask);
+      M2 = Builder.CreateShuffleVector(M2, UndefValue::get(M2->getType()),
+                                       PromoteMaskConst, "promoted_mask");
----------------
Please use poison instead of undef as placeholder whenever possible. We are trying to remove undef from LLVM.
Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139074/new/

https://reviews.llvm.org/D139074



More information about the llvm-commits mailing list