[PATCH] D139069: [lld-macho] Ignored aliases to weak symbols should not retain section data

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added inline comments.


================
Comment at: lld/MachO/UnwindInfoSection.cpp:209
   if (!p.second && d->unwindEntry) {
-    assert(!p.first->second->unwindEntry);
+    assert(p.first->second == d || !p.first->second->unwindEntry);
     p.first->second = d;
----------------
i wonder if this assert could be stricter (ie., how do we know this `p.first->second == d` is true because of the alias-symbol reuse  (from InputFiles ~line 872) and not some bug where the same set of symbols are being added twice ....


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139069/new/

https://reviews.llvm.org/D139069