[PATCH] D63401: SROA: Simplify addrspacecasted allocas with volatile accesses

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 18:34:29 PST 2022


arsenm added a comment.

In D63401#3960116 <https://reviews.llvm.org/D63401#3960116>, @lebedev.ri wrote:

> Is there sufficient test coverage for this?
> Did you check and ensure that this works as intended
> on the addressspace-heavy code and does not miscompile it?

Every AMDGPU alloca has a non-0 address space, and this passed regular testing at some point (which includes some specific I-want-to-break-the-stack volatile tests). Volatile stack objects aren't super common for GPU code since that kind of defeats the point


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63401/new/

https://reviews.llvm.org/D63401



More information about the llvm-commits mailing list