[PATCH] D138774: Enhance stack protector

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D138774#3962173 <https://reviews.llvm.org/D138774#3962173>, @xiangzhangllvm wrote:

> In D138774#3960170 <https://reviews.llvm.org/D138774#3960170>, @lebedev.ri wrote:
>
>> Did i not literally answer that question in my original comment?
>> That being said, i'm not actually able to find any IR-producing tests for this pass, which is worrying.
>
> Sorry again, let me make more clear, did your "IR-producing tests" means we should check the IR not asm code ?

Yes.

> (Seems it is very normal to check the last asm code when we update IR pass.)

For this pass - apparently. In general - no.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138774/new/

https://reviews.llvm.org/D138774