[PATCH] D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86

[Freddy, Ye via Phabricator via llvm-commits]

FreddyYe added inline comments.


================
Comment at: llvm/lib/CodeGen/ExpandLargeFpConvert.cpp:389
+  Value *Shl =
+      Builder.CreateShl(isSigned ? Sub : IntVal, Builder.getIntN(BitWidth, 1));
+  Builder.CreateBr(SwEpilog);
----------------
LuoYuanke wrote:
> It seems there is many coding style like this. Is it possible that create dead code? However I think they will eventually be deleted in ISel.
There may be some dead codes I don't know here. Though ISel will delete the dead nodes, I will try to delete such codes. I removed two in the next version. You can comment out if your find more.
For `Shl` here, I think it's not dead code since it is always be used by `AAddr0`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137241/new/

https://reviews.llvm.org/D137241