[PATCH] D139051: [PGO][indirect-call-promotion] Add extra parameter check for musttail callsite

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 16:13:57 PST 2022


rnk added inline comments.


================
Comment at: llvm/test/Transforms/PGOProfile/indirect_call_promotion_musttail_typecheck.ll:29
+; CHECK-LABEL: @func2
+; CHECK: {{[0-9]+}} = icmp eq ptr %0, @_ZN6proto28internal12ExtensionSet10ParseFieldEmPKcPKNS_7MessageEPNS0_16InternalMetadataEPNS0_12ParseContextE
+
----------------
I would like to see more of the successfully transformed IR, I want to see if the musttail call is in the tail position, since that's also a verifier requirement.

Can we use https://github.com/llvm/llvm-project/blob/main/llvm/utils/update_test_checks.py for this test? There's not too much extraneous IR.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139051/new/

https://reviews.llvm.org/D139051



More information about the llvm-commits mailing list