[PATCH] D139048: [AArch64] Make opcode switch in tryARM64PackedUnwind comprehensive.

[Eli Friedman via Phabricator via llvm-commits]

efriedma created this revision.
efriedma added a reviewer: mstorsjo.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
efriedma requested review of this revision.
Herald added a project: LLVM.

I don't think compiler-generated code could actually be affected by this, but better to be thorough.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D139048

Files:
  llvm/lib/MC/MCWin64EH.cpp


Index: llvm/lib/MC/MCWin64EH.cpp
===================================================================
--- llvm/lib/MC/MCWin64EH.cpp
+++ llvm/lib/MC/MCWin64EH.cpp
@@ -999,6 +999,22 @@
       // These are never canonical; they don't show up with the usual Arm64
       // calling convention.
       return false;
+    case Win64EH::UOP_AllocLarge:
+      // Allocations this large can't be represented in compact unwind (and
+      // usually don't fit the canonical form anyway because we need to use
+      // __chkstk to allocate the stack space).
+      return false;
+    case Win64EH::UOP_AddFP:
+      // "add x29, sp, #N" doesn't show up in the canonical pattern (except for
+      // N=0, which is UOP_SetFP).
+      return false;
+    case Win64EH::UOP_TrapFrame:
+    case Win64EH::UOP_Context:
+    case Win64EH::UOP_ClearUnwoundToCall:
+      // These are special opcodes that aren't normally generated.
+      return false;
+    default:
+      report_fatal_error("Unknown Arm64 unwind opcode");
     }
   }
   if (RegI > 10 || RegF > 8)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139048.479078.patch
Type: text/x-patch
Size: 1049 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221130/01cf8c82/attachment.bin>