[PATCH] D138955: [AArch64] Make sure we don't emit packed unwind for .seh_save_any_reg_p

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 13:36:11 PST 2022


mstorsjo added a comment.

In D138955#3961548 <https://reviews.llvm.org/D138955#3961548>, @efriedma wrote:

> Looking a bit more closely, it looks like the following opcodes don't show up in the switch:
>
> UOP_AllocLarge
> UOP_AddFP
> UOP_TrapFrame
> UOP_Context
> UOP_ClearUnwoundToCall
>
> Not sure if this actually leads to issues in practice, but I'll follow up to address.

Ok, so then we can't make it an unreachable unless we add those as well. In that case, I guess `default: return false;` would be simplest/safest?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138955/new/

https://reviews.llvm.org/D138955



More information about the llvm-commits mailing list