[PATCH] D11621: AMDGPU/SI: Mark SMRD instructions as rematerializable

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 11:37:29 PST 2022


rampitec added a comment.

In D11621#3958649 <https://reviews.llvm.org/D11621#3958649>, @arsenm wrote:

> In D11621#3958647 <https://reviews.llvm.org/D11621#3958647>, @rampitec wrote:
>
>> I do not think this is OK. We may issue a scalar load before a first potentially aliasing store. After the store it must become a VMEM load because caches are not coherent. That said you cannot reorder SMRD with aliasing VMEM store, both because of the coherency and because memory may be indeed overwritten.
>
> This only happens for invariant MMOs. This isn't the only condition

Where is that checked? Also needs tests, both positive and negative.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D11621/new/

https://reviews.llvm.org/D11621



More information about the llvm-commits mailing list