[PATCH] D138977: [IR][NFC] Adds BasicBlock::splice().

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/include/llvm/IR/BasicBlock.h:466
+    auto FromItLast = std::next(FromIt);
+    if (ToIt == FromIt || ToIt == FromItLast)
+      return;
----------------
should add a test for this, e.g. `splice(I1, I2)` where `I1` is right before `I2` in the same block


================
Comment at: llvm/unittests/IR/BasicBlockTest.cpp:386
+
+TEST(BasicBlockTest, SpliceFromFirstLast) {
+  LLVMContext Ctx;
----------------
this name is confusing, not sure what it's referring to


================
Comment at: llvm/unittests/IR/BasicBlockTest.cpp:415
+  Instruction *ToRet = &*ToBBIt++;
+  ToBB->splice(ToI1->getIterator(), FromBB, FromI2->getIterator(),
+               FromBr->getIterator());
----------------
perhaps also test when we splice more than one instruction this way? e.g. `FromI1` instead


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138977/new/

https://reviews.llvm.org/D138977