[PATCH] D138991: [AAPointerInfo] handle multiple offsets in PHI

Wed Nov 30 11:15:34 PST 2022

jdoerfert added inline comments.

================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1091
+  Pass *LegacyPass = nullptr;
 };

----------------
arsenm wrote:
> aeubanks wrote:
> > arsenm wrote:
> > > jdoerfert wrote:
> > > > Do we really need legacy PM support? I would prefer not to add complexity for it.
> > > Yes. Contrary to popular belief, the new PM is not complete. Until we have codegen support, we need legacy PM support for IR passes run in the backend
> > is it possible to run whatever pass you're interested in as part of the optimization pipeline?
> Not in the right place. We can't even move all the IR passes because of the one RegionPass which new PM doesn't have.
Shouldn't we invest the time and code to provide a "region pass wrapper"? We stopped testing most of these things with the old PM, using it is not a great idea.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138991/new/

https://reviews.llvm.org/D138991