[PATCH] D139008: Intrinsics: Make is_fpclass and arithmetic_fence speculatable

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:715
+  def int_arithmetic_fence : DefaultAttrsIntrinsic<[llvm_anyfloat_ty], [LLVMMatchType<0>],
+                                                   [IntrNoMem]>;
 
----------------
The subject line says this is now speculatable but the definition here is not. I'm confused.
Given the description, this "fence" doesn't actually do anything except provide a semi-permeable value pass-through, right? Then I agree this should be speculatable.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:763
                             [llvm_anyfloat_ty, llvm_i32_ty],
-                            [IntrNoMem, IntrWillReturn, ImmArg<ArgIndex<1>>]>;
+                            [IntrNoMem, IntrWillReturn, IntrSpeculatable, ImmArg<ArgIndex<1>>]>;
 
----------------
WillReturn is implied by default, I think


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139008/new/

https://reviews.llvm.org/D139008