[PATCH] D137811: InstCombine: Port amdgcn.class intrinsic combines to is.fpclass

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:847
+  // fp_class (nnan x), qnan|snan|other -> fp_class (nnan x), other
+  if ((Mask & fcNan) && isKnownNeverNaN(Src0, &getTargetLibraryInfo())) {
+    return replaceOperand(II, 1,
----------------
jyknight wrote:
> These removal of Mask bits should come before the `Mask == $X` tests, shouldn't they?
I assume that this function will be called again to revisit the modified instrinsic.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137811/new/

https://reviews.llvm.org/D137811