[PATCH] D138774: Enhance stack protector

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D138774#3959161 <https://reviews.llvm.org/D138774#3959161>, @xiangzhangllvm wrote:

> In D138774#3958882 <https://reviews.llvm.org/D138774#3958882>, @lebedev.ri wrote:
>
>> This pass operates on IR, so it should have IR-based tests (it should be fine to also have codegen tests, since that is a early-codegen ir based pass)
>
> Do you mean we should only check IR? I think choose 1 target (e.g X86) to check the asm code may be better. Thanks for review!

Did i not literally answer that question in my original comment?
That being said, i'm not actually able to find any IR-producing tests for this pass, which is worrying.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138774/new/

https://reviews.llvm.org/D138774