[PATCH] D139000: [AMDGPU] Clear bodies of function with incompatible features

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:217
+static cl::opt<bool> ClearIncompatibleFunctionsBodies(
+    "amdgpu-incompatible-features-clear-fns", cl::Hidden,
+    cl::desc("Enable deletion of function bodies when they"
----------------
Pierre-vh wrote:
> foad wrote:
> > Can you make the name of the option match the name of the pass? It seems like you have three variations in this patch:
> > - clear incompatible functions
> > - clear incompatible functions bodies
> > - incompatible features clear fns
> Matching the name of the pass is not possible because the pass already generates a CL Option I think, but I tried to make it more consistent.
Maybe use -amdgpu-enable-* instead of just -amdgpu-* then? I see a few examples like that already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139000/new/

https://reviews.llvm.org/D139000