[PATCH] D139002: [AMDGPU] Remove todo about vector types

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne created this revision.
sebastian-ne added reviewers: matejam, dstuttard, foad.
Herald added subscribers: kosarev, kerbowa, hiraditya, tpr, yaxunl, jvesely, kzhuravl, arsenm.
Herald added a project: All.
sebastian-ne requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

D138205 <https://reviews.llvm.org/D138205> added all the new vector types, so the todo is fixed now.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D139002

Files:
  llvm/lib/Target/AMDGPU/MIMGInstructions.td


Index: llvm/lib/Target/AMDGPU/MIMGInstructions.td
===================================================================
--- llvm/lib/Target/AMDGPU/MIMGInstructions.td
+++ llvm/lib/Target/AMDGPU/MIMGInstructions.td
@@ -1133,8 +1133,6 @@
 
 class MIMG_IntersectRay_Helper<bit Is64, bit A16> {
   int num_addrs = !if(Is64, !if(A16, 9, 12), !if(A16, 8, 11));
-  // TODO: MIMGAddrSize will choose VReg_512 which is a 16 register tuple,
-  // when we only need 9, 11 or 12 depending on A16 field and ptr size.
   RegisterClass RegClass = MIMGAddrSize<num_addrs, 0>.RegClass;
   int VAddrDwords = !srl(RegClass.Size, 5);
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139002.478892.patch
Type: text/x-patch
Size: 614 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221130/8e9cb034/attachment.bin>