[PATCH] D138990: [AArch64] Enable the select optimize pass for AArch64

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 03:42:23 PST 2022


SjoerdMeijer added a comment.

In D138990#3959676 <https://reviews.llvm.org/D138990#3959676>, @dmgreen wrote:

> In D138990#3959670 <https://reviews.llvm.org/D138990#3959670>, @SjoerdMeijer wrote:
>
>> In the mean, how about compile times? Did you measure that by any chance?
>
> Hmm. I have not, but this is only a scan over the instructions in each function, not anything that isn't done many times in the compiler already. I can check that is true though and there isn't anything costly hiding in it.

Thanks, and yes, that's what I was expecting, i.e. this to be a simple scan and thus not contributing much. Thought it would be good to check, to avoid possibly getting surprised for a reason we had not thought about.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138990/new/

https://reviews.llvm.org/D138990



More information about the llvm-commits mailing list