[PATCH] D138550: [ELF] Combine .riscv.attributes

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

This seems a sensible approach to me. One quick question about the commenting approach - I think the patch summary provides a really nice clear description of the desired behaviour for merging attributes and where it comes from. Putting some of that information / justification into RISCV.cpp would I think be an improvement - at least pointing to the specification for this behaviour and noting that deprecated tags are included in the output only if all inputs have the same value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138550/new/

https://reviews.llvm.org/D138550