[PATCH] D138595: [llvm-cxxfilt] Support Microsoft demangling format

Tobias Hieta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 03:20:25 PST 2022


thieta added a comment.

In D138595#3957652 <https://reviews.llvm.org/D138595#3957652>, @dblaikie wrote:

> Ping on this ^?

Ah sorry - I thought I replied to this, but I just replied in my head.

Yes, I like this idea, but it does feel like we are getting into the territory where we have to refactor the API to demangle since the demangle functions have different return values and handling.

I am happy to do this, but I am not sure it's part of this diff. IMHO it's probably better to land this and then refactor the demangle API in its own diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138595/new/

https://reviews.llvm.org/D138595



More information about the llvm-commits mailing list