[PATCH] D138717: [AArch64][SME]: Add streaming-compatible testing files.(frame-offsets.ll, int-immediates.ll, log-reduce.ll)

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-frame-offsets.ll:8
+
+; Ensure that only no offset frame indexes are folded into SVE load/stores when
+; accessing fixed width objects.
----------------
I don't see the value of this test, given that this test uses no SVE loads/stores. I think you can just remove the whole file?


================
Comment at: llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-int-immediates.ll:5
+target triple = "aarch64-unknown-linux-gnu"
+
+; Although SVE immediate packing should be fully tested using scalable vectors,
----------------
This change needs a FIXME, because none of the instructions use the immediate form.


================
Comment at: llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-int-immediates.ll:14
+
+define void @add_v32i8(<32 x i8>* %a) #0 {
+; CHECK-LABEL: add_v32i8:
----------------
Please use opaque pointers for all tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138717/new/

https://reviews.llvm.org/D138717