[llvm] 851176c - [AMDGPU] Remove AMDGPUISelDAGToDAG::isKnownNeverNaN
Thomas Symalla via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 29 22:58:38 PST 2022
Author: Thomas Symalla
Date: 2022-11-30T07:58:32+01:00
New Revision: 851176c7f760ca27ef6aff4ab0b6491afd7b0304
URL: https://github.com/llvm/llvm-project/commit/851176c7f760ca27ef6aff4ab0b6491afd7b0304
DIFF: https://github.com/llvm/llvm-project/commit/851176c7f760ca27ef6aff4ab0b6491afd7b0304.diff
LOG: [AMDGPU] Remove AMDGPUISelDAGToDAG::isKnownNeverNaN
This function removes the mentioned function, as it only does two
checks which are already implemented as part of
SelectionDAG::isKnownNeverNaN - which is called there.
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D138938
Added:
Modified:
llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h
Removed:
################################################################################
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp b/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
index 2f51bf82f0797..66d7efd676fff 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
@@ -316,17 +316,6 @@ void AMDGPUDAGToDAGISel::PreprocessISelDAG() {
}
}
-bool AMDGPUDAGToDAGISel::isNoNanSrc(SDValue N) const {
- if (TM.Options.NoNaNsFPMath)
- return true;
-
- // TODO: Move into isKnownNeverNaN
- if (N->getFlags().hasNoNaNs())
- return true;
-
- return CurDAG->isKnownNeverNaN(N);
-}
-
bool AMDGPUDAGToDAGISel::isInlineImmediate(const SDNode *N,
bool Negated) const {
if (N->isUndef())
@@ -2643,7 +2632,7 @@ bool AMDGPUDAGToDAGISel::SelectVOP3BMods(SDValue In, SDValue &Src,
bool AMDGPUDAGToDAGISel::SelectVOP3Mods_NNaN(SDValue In, SDValue &Src,
SDValue &SrcMods) const {
SelectVOP3Mods(In, Src, SrcMods);
- return isNoNanSrc(Src);
+ return CurDAG->isKnownNeverNaN(Src);
}
bool AMDGPUDAGToDAGISel::SelectVOP3NoMods(SDValue In, SDValue &Src) const {
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h b/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h
index 1a8e8f622cdd0..b516dcb9e39b7 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h
+++ b/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h
@@ -110,7 +110,6 @@ class AMDGPUDAGToDAGISel : public SelectionDAGISel {
private:
std::pair<SDValue, SDValue> foldFrameIndex(SDValue N) const;
- bool isNoNanSrc(SDValue N) const;
bool isInlineImmediate(const SDNode *N, bool Negated = false) const;
bool isNegInlineImmediate(const SDNode *N) const {
return isInlineImmediate(N, true);
More information about the llvm-commits
mailing list