[PATCH] D138774: Enhance stack protector

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 21:31:21 PST 2022


xiangzhangllvm added a comment.

In D138774#3958882 <https://reviews.llvm.org/D138774#3958882>, @lebedev.ri wrote:

> This pass operates on IR, so it should have IR-based tests (it should be fine to also have codegen tests, since that is a early-codegen ir based pass)

Do you mean we should only check IR? I think choose 1 target (e.g X86) to check the asm code may be better. Thanks for review!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138774/new/

https://reviews.llvm.org/D138774



More information about the llvm-commits mailing list