[PATCH] D113443: [FreeBSD] avoid marking __stack_chk_guard symbol as dso_local on PPC64

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringBase.cpp:1991-1997
+    // XXX -- needs more investigation
+    // FreeBSD userland has "__stack_chk_guard" defined externally on libc.so,
+    // so not dso_local. Kernel modules are compiled in freestanding mode, it
+    // can be considered dso_local. For unknown reasons set dso_local here
+    // breaks PPC64 userland binaries (see bug #51590).
+    // However, FreeBSD amd64 kernel and modules are broken if dso_local
+    // is not set here, while PCC64 kernel and modules are fine without it.
----------------
maybe something like this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113443/new/

https://reviews.llvm.org/D113443