[PATCH] D138893: [llvm-profdata] Use flattening sample profile in profile supplementation

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:691
+                            &InstrProfileMap](const FunctionSamples &FS,
+                                              const StringRef &RootName) {
+    auto BuildMaxSampleMapImpl = [&](const FunctionSamples &FS,
----------------
I am not sure if RootName parameter is actually needed here. In the code below, it is either be overwritten (with newroot), or used in cases we don't care -- i.e., function not found in instr profile.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138893/new/

https://reviews.llvm.org/D138893