[PATCH] D138890: [FuzzMutate] Fix a bug in `connectToSink` which might invalidate the whole module.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 12:48:26 PST 2022


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with nits



================
Comment at: llvm/lib/FuzzMutate/RandomIRBuilder.cpp:95
+  // Modify other operands, like switch case may accidently change case from
+  // ConstnatInt to a register, which is illegal.
+  case Instruction::Switch:
----------------
Typo ConstnatInt


================
Comment at: llvm/unittests/FuzzMutate/RandomIRBuilderTest.cpp:337
+    IB.connectToSink(*BB, ConnectAfter, Inst);
+    ASSERT_TRUE(!verifyModule(*M, &errs()));
+  }
----------------
ASSERT_FALSE(verifyModule)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138890/new/

https://reviews.llvm.org/D138890



More information about the llvm-commits mailing list