[PATCH] D138942: Support: Make Wait's SecondsToWait be Optional [NFC]

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 12:38:46 PST 2022


arsenm created this revision.
arsenm added reviewers: craig.topper, hubert.reinterpretcast, sepavloff, tareqsiraj, zturner, aganea, alexfh.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

I found the interaction between SecondsToWait and
WaitUntilChildTerminates confusing. Rather than have a boolean to
ignore the value of SecondsToWait, combine these into one Optional
parameter

No idea if the Windows part builds


https://reviews.llvm.org/D138942

Files:
  llvm/include/llvm/Support/Program.h
  llvm/lib/Support/Program.cpp
  llvm/lib/Support/Unix/Program.inc
  llvm/lib/Support/Windows/Program.inc
  llvm/unittests/Support/ProgramTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138942.478681.patch
Type: text/x-patch
Size: 7358 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221129/b009780b/attachment.bin>


More information about the llvm-commits mailing list