[PATCH] D105067: [SystemZ] Emit .gnu_attribute for an externally visible vector abi.

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 08:04:08 PST 2022


jonpa updated this revision to Diff 478601.
jonpa added a comment.

I tried to move the handling of functions into computeInfo(), but found that it is not possible to know from a CGFunctionInfo if the function is externally visible or not. It does however seem like all vararg calls go through here (for normal functions only the declaration/definition is processed), which is fortunate as it happens that even a local vararg call should be regarded (the va_list could be passed to another global function potentially). I could therefore remove the new target hook I had added for the purpose of checking varargs.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105067/new/

https://reviews.llvm.org/D105067

Files:
  clang/lib/CodeGen/CodeGenTypes.h
  clang/lib/CodeGen/TargetInfo.cpp
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-00.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-01.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-02.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-03.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-04.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-05.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-06.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-07.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-08.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-09.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-10.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-11.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-12.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-13.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-14.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-15.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-16.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-17.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-18.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-19.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-20.cpp
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-21.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-22.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-23.c
  clang/test/CodeGen/SystemZ/vec-abi-gnuattr-24.c
  llvm/lib/Target/SystemZ/AsmParser/SystemZAsmParser.cpp
  llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp
  llvm/lib/Target/SystemZ/SystemZAsmPrinter.h
  llvm/test/MC/SystemZ/gnu-attributes.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105067.478601.patch
Type: text/x-patch
Size: 28323 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221129/e5e02f9a/attachment.bin>


More information about the llvm-commits mailing list