[PATCH] D138595: [llvm-cxxfilt] Support Microsoft demangling format

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 06:59:27 PST 2022


jhenderson added a comment.

In D138595#3957034 <https://reviews.llvm.org/D138595#3957034>, @thieta wrote:

> In D138595#3957002 <https://reviews.llvm.org/D138595#3957002>, @jhenderson wrote:
>
>> Actually, don't you need tests to show that the new `--format` options work as expected?
>
> You mean testing `rust`, `dlang` and `itanium` explicitly? I can definitely add that.

Yep, that's what I meant (I think we have other testing that already tests that we can demangle these name types, so it should be fairly simple to ensure the option values are acceptable too).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138595/new/

https://reviews.llvm.org/D138595



More information about the llvm-commits mailing list