[PATCH] D138853: [InstSimplify] Fold !(X || Y) && X --> false

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 06:11:26 PST 2022


bcl5980 added inline comments.


================
Comment at: llvm/test/Transforms/InstSimplify/select-logical.ll:223
   %not = xor <3 x i1> %l.and, <i1 true, i1 true, i1 true>
   %r = select <3 x i1> %not, <3 x i1> %x, <3 x i1> <i1 true, i1 false, i1 false>
   ret <3 x i1> %r
----------------
spatel wrote:
> The FalseVal of `%r` is not zero, so this is not showing what the comment describes. This might need a TODO if we don't match the first select as logical-or?
I'm sorry , this should be a typo. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138853/new/

https://reviews.llvm.org/D138853



More information about the llvm-commits mailing list