[PATCH] D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/CodeGen/ExpandLargeFpConvert.cpp:151
+  Value *ARep = Builder.CreateZExt(ARep0, FPToI->getType());
+  Value *Tobool_not = Builder.CreateICmpSGT(
+      ARep0, ConstantInt::getSigned(Builder.getIntNTy(FloatWidth), -1));
----------------
LuoYuanke wrote:
> ToBoolNot?
Maybe rename it as PosOrNeg?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137241/new/

https://reviews.llvm.org/D137241