[PATCH] D137241: [X86] Add ExpandLargeFpConvert Pass and enable for X86

[Matthias Gehre via Phabricator via llvm-commits]

mgehre-amd added inline comments.


================
Comment at: llvm/lib/CodeGen/ExpandLargeFpConvert.cpp:90
+/// Replace fp to integer with generated code.
+static bool expandFPToI(Instruction *FPToI) {
+  IRBuilder<> Builder(FPToI);
----------------
The return value is unused at its call site - convert to void?


================
Comment at: llvm/lib/CodeGen/ExpandLargeFpConvert.cpp:233
+/// the generated code. This currently generates code similarly to compiler-rt's
+/// implementations. This implementation has an implicit that integer width is
+/// larger than fp.
----------------
nit: word missing after "implicit"
And can we have an assert for that assumption?


================
Comment at: llvm/lib/CodeGen/ExpandLargeFpConvert.cpp:313
+/// Replace integer to fp with generated code.
+static bool expandIToFP(Instruction *IToFP) {
+  IRBuilder<> Builder(IToFP);
----------------
return void


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137241/new/

https://reviews.llvm.org/D137241